Angle: add support for MT6816, MT6826S sensors #6735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefelim4ag
force-pushed
the
angle-mt68xx
branch
from
c114323 to
bc1ad0d
Compare
|
Thanks. As very high-level feedback, we can certainly add support for these additional sensors. The code would need to pass the regression tests though. Cheers, |
|
But for now it is failing because of image limitations: The only idea that I have is to disable angle sensors for ar100. |
nefelim4ag
force-pushed
the
angle-mt68xx
branch
2 times, most recently
from
45a2b69 to
78dfd0f
Compare
|
Thanks. I'm fine with adding this. I noticed a couple of minor things:
Cheers, |
nefelim4ag
force-pushed
the
angle-mt68xx
branch
from
78dfd0f to
ecfad26
Compare
Signed-off-by: Timofey Titovets <[email protected]>
Signed-off-by: Timofey Titovets <[email protected]>
nefelim4ag
force-pushed
the
angle-mt68xx
branch
from
ecfad26 to
dbe8ea9
Compare
Signed-off-by: Timofey Titovets <[email protected]>
Signed-off-by: Timofey Titovets <[email protected]>
nefelim4ag
force-pushed
the
angle-mt68xx
branch
from
dbe8ea9 to
c95fb21
Compare
|
Thanks! -Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this is just a proposal - till there are other real users.
MT6816 - simple 14-bit angle sensor, can be read and that's it.
MT6826S - Has calibration capabilities - implemented, hysteresis, and 15-bit output
MT6835 - (21 bit) should work with code from MT6826S, we anyway will ignore additional bits.
For now, I mostly play around with MT6826S.
Thanks.
BTW, it would be nice to have a generic query command for the angle sensor, like
ACCELEROMETER_QUERY.